Fix context size configuration precedence#846
Closed
krissetto wants to merge 1 commit intodocker:mainfrom
Closed
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the backend configuration logic to prioritize runtime settings over model defaults, specifically for the context size. It also refines the CLI to only transmit the context size when the flag is explicitly set. A critical feedback point notes that the context size value lacks range validation before being cast to a 32-bit integer, which could result in overflow or truncation.
User configured context should always be applied over the packaged context size Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
krissetto
force-pushed
the
fix-ctx-config
branch
from
e0e2fe8 to
9ae3f1a
Compare
Collaborator
Author
|
closing in favor of #847 <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm pretty sure user configured context should always be applied over the packaged context size.
Opening as draft to make sure this aligns with the project, and because it needs further testing